dev dependencies: allow latest versions#3311
Merged
donoghuc merged 1 commit intopuppetlabs:mainfrom May 9, 2024
Merged
Conversation
This updates all version constraints for development dependencies in gemspec to allow their latest major versions. Followup for puppetlabs#3249
bastelfreak
added a commit
to bastelfreak/bolt
that referenced
this pull request
May 9, 2024
This also contains puppetlabs#3311
bastelfreak
added a commit
to bastelfreak/bolt
that referenced
this pull request
May 9, 2024
This also contains puppetlabs#3311
bastelfreak
added a commit
to bastelfreak/bolt
that referenced
this pull request
May 9, 2024
This also updates the orchestrator_client dependency. It requires faraday 1.x. Older versions of orchestrator_client also depend on faraday but didn't specify the version requirement. r10k 4 depends on a newer puppet_forge gem which in turn depends on faraday 2. If we only bump r10k we will downgrade orchestrator_client from 0.7.0 to 0.5.3, which we probably don't want. Result => orchestrator_client needs to be updated to work with faraday 2. And that' doesn't support Ruby 2.5 anymore. This also contains puppetlabs#3311
bastelfreak
added a commit
to bastelfreak/bolt
that referenced
this pull request
May 9, 2024
This also updates the orchestrator_client dependency. It requires faraday 1.x. Older versions of orchestrator_client also depend on faraday but didn't specify the version requirement. r10k 4 depends on a newer puppet_forge gem which in turn depends on faraday 2. If we only bump r10k we will downgrade orchestrator_client from 0.7.0 to 0.5.3, which we probably don't want. Result => orchestrator_client needs to be updated to work with faraday 2. (which is actually implemented but unreleased). This also contains puppetlabs#3311
donoghuc
approved these changes
May 9, 2024
bastelfreak
added a commit
to bastelfreak/bolt
that referenced
this pull request
May 9, 2024
This also updates the orchestrator_client dependency. It requires faraday 1.x. Older versions of orchestrator_client also depend on faraday but didn't specify the version requirement. r10k 4 depends on a newer puppet_forge gem which in turn depends on faraday 2. If we only bump r10k we will downgrade orchestrator_client from 0.7.0 to 0.5.3, which we probably don't want. Result => orchestrator_client needs to be updated to work with faraday 2. (which is actually implemented but unreleased). This also contains puppetlabs#3311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates all version constraints for development dependencies in gemspec to allow their latest major versions.
Followup for #3249