added workaround for https://youtrack.jetbrains.com/issue/KT-30289#339
Open
woggioni wants to merge 1 commit intopuniverse:masterfrom
Open
added workaround for https://youtrack.jetbrains.com/issue/KT-30289#339woggioni wants to merge 1 commit intopuniverse:masterfrom
woggioni wants to merge 1 commit intopuniverse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix quasar issue with Kotlin 1.3, the idea is to instrument any static synthetic method whose name ends with
$defaultif it comes after a suspendable method with the same name (except for the $default suffix) and a similar signature (more details about it will follow).I did some manual testing and it seems to work, it relies on the fact that the Kotlin compiler writes the
$defaultmethods only after their base counterparts (which could be problematic since, although this is the current behavior, there is no guarantee around its stability).