Skip to content

Fix FiberAsyncTest.whenCancelRunBlockingInterruptExecutingThread() #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixvf wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix FiberAsyncTest.whenCancelRunBlockingInterruptExecutingThread() #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd9abd
Increase failure chance of FiberAsyncTest.whenCancelRunBlockingInterr…
May 2, 2017
8aef9a5
Ignore FiberAsyncTest.whenCancelRunBlockingInterruptExecutingThread()…
May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 34 additions & 31 deletions quasar-core/src/test/java/co/paralleluniverse/fibers/FiberAsyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,42 +313,45 @@ public void run() throws SuspendExecution {
fiber.join();
}

@Ignore // FIXME: This test currently fails and needs to be investigated.
@Test
public void whenCancelRunBlockingInterruptExecutingThread() throws Exception {
final AtomicBoolean started = new AtomicBoolean();
final AtomicBoolean interrupted = new AtomicBoolean();

Fiber fiber = new Fiber(new SuspendableRunnable() {
@Override
public void run() throws SuspendExecution, InterruptedException {
FiberAsync.runBlocking(Executors.newSingleThreadExecutor(),
new CheckedCallable<Void, RuntimeException>() {
@Override
public Void call() throws RuntimeException {
started.set(true);
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
interrupted.set(true);
for (int i = 0;i<100;i++) {
final AtomicBoolean started = new AtomicBoolean();
final AtomicBoolean interrupted = new AtomicBoolean();

Fiber fiber = new Fiber(new SuspendableRunnable() {
@Override
public void run() throws SuspendExecution, InterruptedException {
FiberAsync.runBlocking(Executors.newSingleThreadExecutor(),
new CheckedCallable<Void, RuntimeException>() {
@Override
public Void call() throws RuntimeException {
started.set(true);
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
interrupted.set(true);
}
return null;
}
return null;
}
});
}
});

fiber.start();
Thread.sleep(100);
fiber.cancel(true);
try {
fiber.join(5, TimeUnit.MILLISECONDS);
fail("InterruptedException not thrown");
} catch(ExecutionException e) {
if (!(e.getCause() instanceof InterruptedException))
});
}
});

fiber.start();
Thread.sleep(100);
fiber.cancel(true);
try {
fiber.join(5, TimeUnit.MILLISECONDS);
fail("InterruptedException not thrown");
} catch(ExecutionException e) {
if (!(e.getCause() instanceof InterruptedException))
fail("InterruptedException not thrown");
}
assertThat(started.get(), is(true));
assertThat(interrupted.get(), is(true));
}
assertThat(started.get(), is(true));
assertThat(interrupted.get(), is(true));
}

@Test
Expand Down