Adopt the "ArtifactResourceBudget" limiter from Pulpcore - #2553
Conversation
5b89e4a to
0c325cf
Compare
Puts a limiter on the amount of data that can be held locally between artifact download and saving (to content storage).
|
Looks like we're missing some locking:
https://github.com/pulp/pulp_ansible/actions/runs/30288613841/job/90052887453?pr=2553#step:18:376 That's unrelated to this PR but should be investigated |
| "jsonschema>=4.9,<4.27", | ||
| "Pillow>=10.3,<13", # Semantic Versioning https://pillow.readthedocs.io/en/stable/releasenotes/versioning.html | ||
| "pulpcore>=3.105.13,<3.130", | ||
| "pulpcore>=3.111.0,<3.130", |
There was a problem hiding this comment.
Is 3.111 supposed to become a supported pulpcore branch any time soon?
(Moving the LB on an unsupported branch is the only thing that makes me a bit cautious here.)
There was a problem hiding this comment.
I could move to 3.115 if you want - I don't think in the past we've made a policy out of not doing that though.
There was a problem hiding this comment.
💥! It looks like we really 🦆 up on this.
StableOrderingFilter (technically a feature) was backported to 3.105 but not 3.111 or anything between those.
Do you think it would be reasonable to add this feature based on whether the import succeeded and leave this constraint alone?
There was a problem hiding this comment.
How valuable is it to keep the constraint wide open vs. just bump the lower bound?
2 participants
Puts a limiter on the amount of data that can be held locally between artifact download and saving (to content storage).
📜 Checklist
See: Pull Request Walkthrough