Skip to content

Clean up and consolidate tests - #28

Merged
puddly merged 26 commits into
devfrom
puddly/consolidate-tests
Mar 6, 2026
Merged

puddly merged 26 commits into
devfrom
puddly/consolidate-tests

Conversation

@puddly

@puddly puddly commented Mar 5, 2026

Copy link
Copy Markdown
Owner

This PR merges all of the generic unit tests into two files: one for sync transports and another for async transports. A few platform-specific test files exist but these are just for functionality that is truly platform-specific.

We create socat and TCP servers internally. com0com is expected to be passed externally via --adapter-pair. Loopback adapter tests are now gone and we only support adapter pairs.

@codecov

codecov Bot commented Mar 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.41509% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.42%. Comparing base (9388651) to head (3cf7437).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
serialx/platforms/serial_win32.py 55.17% 13 Missing ⚠️
serialx/descriptor_transport.py 86.66% 6 Missing ⚠️
serialx/common.py 81.81% 4 Missing ⚠️
serialx/platforms/serial_socket.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #28      +/-   ##
==========================================
+ Coverage   84.37%   85.42%   +1.04%     
==========================================
  Files          11       11              
  Lines        1274     1352      +78     
==========================================
+ Hits         1075     1155      +80     
+ Misses        199      197       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly
puddly merged commit c2cb10b into dev Mar 6, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant