Explicitly specify loopback IP when exposing container ports#34
Open
ok300 wants to merge 1 commit into
Open
Conversation
Updated port mappings to bind to localhost instead of all interfaces.
Contributor
|
could you check please that stack is working, make sure to test registration workflow using pubky ring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common way ports are exposed in docker
8001:8001is actually equivalent to0.0.0.0:8001:8001, which binds the port to all of the host's IPs.Since docker bypasses local firewalls like
ufwandiptables(docker/for-linux#690) , a user that would follow try to run these containers on a VPS VM could inadvertently expose each container's mapped ports to the internet.To follow security best practices, this PR switches to a port notation that explicitly binds it to the host's loopback IP.
Related to pubky/pubky-core#288, pubky/pubky-nexus#676