Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve semicolon-delimited path parameters when Requests builds the digest-auth
urifield.Closes #6990.
Problem
HTTPDigestAuth.build_digest_header()currently rebuilds the request URI from the parsed path and query string only.For URLs whose path includes semicolon-delimited parameters, that drops part of the original request target before Requests hashes it into the
Authorizationheader.Changes
urlparse(url).paramsback onto the digest-auth path before adding the query stringTesting
PYTHONPATH=src python -m pytest tests/test_requests.py -k digestauth -q