Skip to content

Pure PHP: cleanly ignore bits in the 10-byte varints with bit above LSB set. #26871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Draft

Pure PHP: cleanly ignore bits in the 10-byte varints with bit above LSB set. #26871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion php/tests/PhpImplementationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,20 @@ public function testReadVarint64()
$input = new CodedInputStream(hex2bin(''));
$this->assertFalse($input->readVarint64($var));

// The largest varint is 10 bytes long.
// varints which are >10 bytes long aren't allowed
$input = new CodedInputStream(hex2bin('8080808080808080808001'));
$this->assertFalse($input->readVarint64($var));

// 10-byte varint with high bits set in the 10th byte.
// Bits above bit 0 in the 10th byte are discarded.
$input = new CodedInputStream(hex2bin('87808080808080808002'));
$this->assertTrue($input->readVarint64($var));
if (PHP_INT_SIZE == 4) {
$this->assertSame('7', $var);
} else {
$this->assertSame(7, $var);
}

// Corrupted varint.
$input = new CodedInputStream(hex2bin('808080'));
$this->assertFalse($input->readVarint64($var));
Expand Down
Loading