This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Repository navigation
feat: Liquorice executor - #332
Merged
zach030 merged 24 commits intoMar 20, 2026
Merged
Conversation
zach030
reviewed
Mar 13, 2026
zach030
reviewed
Mar 13, 2026
zach030
reviewed
Mar 13, 2026
zach030
reviewed
Mar 13, 2026
zach030
reviewed
Mar 16, 2026
markin-io
force-pushed
the
feat/liquorice-executor
branch
from
March 16, 2026 19:07
6118296 to
f56b9da
Compare
dianacarvalho1
approved these changes
Mar 17, 2026
dianacarvalho1
left a comment
dianacarvalho1
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! Overall it looks good to me! Only left small comments
| givenAmount, originalBaseTokenAmount, minBaseTokenAmount | ||
| ); | ||
|
|
||
| // Transfer tokens to executor |
Collaborator
There was a problem hiding this comment.
when running through the tycho router, address(this) represents the tycho router and not the executor. Can we clean up this comment a bit so it isn't misleading please?
Comment on lines
+46
to
+59
| let config = config.ok_or(EncodingError::FatalError( | ||
| "Missing liquorice specific addresses in config".to_string(), | ||
| ))?; | ||
| let balance_manager_address = config | ||
| .get("balance_manager_address") | ||
| .map(|s| { | ||
| Bytes::from_str(s).map_err(|_| { | ||
| EncodingError::FatalError( | ||
| "Invalid liquorice balance manager address".to_string(), | ||
| ) | ||
| }) | ||
| }) | ||
| .ok_or(EncodingError::FatalError( | ||
| "Missing liquorice balance manager address in config".to_string(), |
Collaborator
There was a problem hiding this comment.
we could make this nicer like
let balance_manager_address = config
.get("balance_manager_address")
.ok_or_else(|| EncodingError::FatalError(
"Missing liquorice balance manager address in config".to_string(),
))
.and_then(|s| {
Bytes::from_str(s).map_err(|_| {
EncodingError::FatalError(
"Invalid liquorice balance manager address".to_string(),
)
})
})?;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executor logic for Liquorice RFQ protocol https://liquorice.tech/