Skip to content

fix: potential race conditions for metrics with no label constraints #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denopink wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: potential race conditions for metrics with no label constraints #1952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009ee68
fix: potential race conditions for metrics with no label constraints
denopink Feb 16, 2026
e639167
Merge branch 'main' into patch-1
kakkoyun Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions prometheus/vec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package prometheus

import (
"fmt"
"maps"
"sync"

"github.com/prometheus/common/model"
Expand Down Expand Up @@ -667,7 +668,8 @@ var labelsPool = &sync.Pool{
func constrainLabels(desc *Desc, labels Labels) (Labels, func()) {
if len(desc.variableLabels.labelConstraints) == 0 {
// Fast path when there's no constraints
return labels, func() {}
// Returning a shallow copy of `labels`
return maps.Clone(labels), func() {}
}

constrainedLabels := labelsPool.Get().(Labels)
Expand All @@ -686,7 +688,8 @@ func constrainLabels(desc *Desc, labels Labels) (Labels, func()) {
func constrainLabelValues(desc *Desc, lvs []string, curry []curriedLabelValue) []string {
if len(desc.variableLabels.labelConstraints) == 0 {
// Fast path when there's no constraints
return lvs
// Returning a shallow copy of `lvs`
return append(make([]string, 0, len(lvs)), lvs...)
}

constrainedValues := make([]string, len(lvs))
Expand Down
Loading