Build remote attestation for UEFI#2693
Merged
Merged
Conversation
jul-sh
requested review from
andrisaar,
conradgrobler,
ipetr0v and
rbehjati
and removed request for
a team and
rbehjati
jul-sh
added
the
approval/any
conradgrobler
approved these changes
Apr 8, 2022
| uefi = { version = "*", features = ["exts"] } | ||
| uefi-services = "*" | ||
| log = { version = "*" } | ||
| oak_remote_attestation = { path = "../../../remote_attestation/rust" } |
Collaborator
There was a problem hiding this comment.
I am surprised this does not cause cargo udeps to complain, seeing that the code does not currently use anything from the remote attestation crate. Do we ignore the UEFI app when running cargo udeps?
Author
There was a problem hiding this comment.
Good catch, forgot about us using cargo udeps. The reason it doesn't complain is that we run it on the workspace, and the UEFI app is excluded from the workspace bc of #2654.
Should we keep this as is? This crate should start actually using this dep fairly soon.
Collaborator
There was a problem hiding this comment.
I think it is fine for now, but we should probably update xtask at some point to run cargo udeps for this as well.
andrisaar
reviewed
Apr 8, 2022
andrisaar
approved these changes
Apr 8, 2022
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 728a5d2..162f99d 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,2 +1,2 @@
-8a7d039cbdea7691dee83744f996b941eb3f174a9eb9376c5b8e06c49fb38f21 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
-9142c165d3c22874be1293d4f1c7f15341d18cc363f79f77931b95668d5c98db ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe
+2ed61030604ebf6ce86489399886cbf4422c623c4c4ce81e621792a01b979e99 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
+d83458c923437b35df01f3d8a72dc55ae4d32a6eb9f91626356893c519d6e3b0 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.