Conversation
When a single word is longer than the line layout limit (often happening with ad-hoc command URIs), `_win_print_wrapped` splits and prints the word char by char. We used `g_utf8_strncpy(copy, word_ch, 1)` to copy a single character. But `g_utf8_strncpy` does not null terminate the destination buffer if the character limit is reached before encountering a NUL. The result was stack garbage being passed to ncurses `waddstr` causing corrupted console rendering. Fixes: #1949 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
When users join MUCs or start chats, they may input mixed case strings (`Room@Conference.Example.Com`). The server normalize JIDs to lowercase, so incoming server responses and events use lowercase. JID based window lookups used `g_strcmp0` for case sensitive matching. When a server response arrived for a window initialized with mixed case the lookup failed. Ref: #1949 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.