-
Notifications
You must be signed in to change notification settings - Fork 312
feat: add @generated attribute for stored generated columns (PostgreSQL) #5800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bilby91
wants to merge
11
commits into
prisma:main
Choose a base branch
from
crunchloop:feat/generated-columns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4456be4
feat: add @generated attribute for stored generated columns (PostgreSQL)
bilby91 a3f9d1f
feat: add generatedColumns preview feature flag and migration tests
bilby91 d4cc9c4
fix: address review feedback — PG 9-11 compatibility and diff comments
bilby91 5d2a16d
fix: address CodeRabbit review feedback
bilby91 c7dd947
fix: critical default alignment bug and comment accuracy
bilby91 d716af6
fix: add connector-specific validation for @generated
bilby91 f1f6b21
fix: improve error spans and attribute name formatting
bilby91 6e3a9ee
fix: validate @generated against both @id and @@id
bilby91 6be80c2
fix: use @generated prefix consistently in all error messages
bilby91 3a924ee
fix: exclude generated columns from createMany input
bilby91 d7f80cf
fix: test all mutation input types and guard against empty connector
bilby91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| use crate::{Provider, common::*, with_header}; | ||
|
|
||
| #[test] | ||
| fn should_fail_without_preview_feature() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| calc Int? @generated("id * 2") | ||
| } | ||
| "#}; | ||
|
|
||
| // No "generatedColumns" in preview features | ||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &[])); | ||
|
|
||
| assert!(error.contains("preview feature")); | ||
| assert!(error.contains("generatedColumns")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn should_fail_without_expression_argument() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| name String @generated | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("Argument")); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| #[test] | ||
| fn should_fail_with_non_string_argument() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| calc Int @generated(42) | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("string")); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| #[test] | ||
| fn should_fail_when_combined_with_default() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| calc Int? @generated("id * 2") @default(0) | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("@default")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn should_fail_when_combined_with_updated_at() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| ts DateTime @generated("now()") @updatedAt | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("@updatedAt")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn should_fail_when_combined_with_id() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id @generated("1") | ||
| name String | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("@id")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn should_fail_on_list_field() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| tags Int[] @generated("ARRAY[1,2,3]") | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Postgres, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("list")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn should_fail_on_unsupported_connector() { | ||
| let dml = indoc! {r#" | ||
| model User { | ||
| id Int @id | ||
| calc Int? @generated("id * 2") | ||
| } | ||
| "#}; | ||
|
|
||
| let error = parse_unwrap_err(&with_header(dml, Provider::Mysql, &["generatedColumns"])); | ||
|
|
||
| assert!(error.contains("@generated")); | ||
| assert!(error.contains("not supported")); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.