feature: inline support for f16 - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement #18 but without requiring stable rust-lang/rust#116909 (since it's been years and it's not stable yet, so I want to just fix the bug in this library since otherwise every f16-encoded float read by any cbor_event consumer is silently corrupted)
Quick Q&A on the implementation
Q: Why didn't you just use a crate
A: Because this project is meant to have zero dependencies (per the README)
Q: How do you know the implementation is correct
A: There is a crate called
halfthat gives f16 support before it's part of stable. I added this as a dev dependency, and checked that results match for all possible f16 (for bits in 0..=u16::MAX {)Related issue: #10