Migrate navigation roots to mergeProps - #8298
Draft
joshblack wants to merge 4 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 057b4de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
joshblack
force-pushed
the
migrate/merge-props-batch-06
branch
from
August 12, 2026 16:24
da45c77 to
ef26f65
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84a0d8ca-13d3-4cb2-ab24-18fa2d9a8a14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84a0d8ca-13d3-4cb2-ab24-18fa2d9a8a14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84a0d8ca-13d3-4cb2-ab24-18fa2d9a8a14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84a0d8ca-13d3-4cb2-ab24-18fa2d9a8a14
joshblack
force-pushed
the
migrate/merge-props-batch-06
branch
from
August 13, 2026 21:25
ef26f65 to
057b4de
Compare
joshblack
had a problem deploying
to
github-pages
August 13, 2026 21:30 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ADR-025 prop merging migration.
This PR updates our page and navigation component families to merge component-authored and consumer-authored props through
mergeProps. The migration preserves consumer precedence, class names, refs, handlers, and accessibility behavior while removing 45 findings from the migration report.Changelog
New
UnderlinePanels.Panel.Changed
UnderlinePanels.Paneltypes to exclude attributes that are always controlled by the component.Removed
aria-labelledby,data-selected,hidden,id, androleattributes from the publicUnderlinePanels.PanelTypeScript surface.Rollout strategy
This corrects the public types to match existing runtime behavior. UnderlinePanels already owns each panel's ID, role, visibility, selected state, and accessible relationship.
Testing & Reviewing
UnderlinePanels.Panelattributes and patch changeset.@primer/reacttype-check pass.