-
Notifications
You must be signed in to change notification settings - Fork 672
UnderlineNav: Show item icons above medium by default #8260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+39
−5
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
af3bbeb
default hideIconsBreakpoint to xsmall
liuliu-dev 27ab730
revert the test change
liuliu-dev fa9ba99
test(vrt): update snapshots
liuliu-dev 7f79f84
revert actionmenu snapshot update
liuliu-dev f7c8634
Merge branch 'main' into liuliu/underline-nav-icon-breakpoint
liuliu-dev 51f391b
update test to wait
liuliu-dev e5e14d3
Merge branch 'liuliu/underline-nav-icon-breakpoint' of https://github…
liuliu-dev 33c6069
test(vrt): update snapshots
liuliu-dev 2e0465c
matches main
liuliu-dev 226f863
xsmal->medium, add documentation for hideIconsBreakpoint prop
liuliu-dev 6a4ea03
Merge branch 'main' into liuliu/underline-nav-icon-breakpoint
liuliu-dev 6e9da2f
Merge remote-tracking branch 'origin/main' into liuliu/underline-nav-…
liuliu-dev 33913e2
Merge branch 'main' into liuliu/underline-nav-icon-breakpoint
liuliu-dev ca7d339
Merge branch 'main' into liuliu/underline-nav-icon-breakpoint
liuliu-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': patch | ||
| --- | ||
|
|
||
| UnderlineNav: Keep item icons visible by default except below the xsmall breakpoint | ||
Binary file modified
BIN
+1.04 KB
(100%)
...Header.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+912 Bytes
(100%)
...PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.11 KB
(100%)
...der.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.04 KB
(100%)
...onents/PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.05 KB
(100%)
...Header.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.14 KB
(100%)
...eader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.12 KB
(100%)
...er.test.ts-snapshots/PageHeader-Pull-Request-Page-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.15 KB
(100%)
...nents/PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.14 KB
(100%)
...eader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.04 KB
(100%)
...shots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+912 Bytes
(100%)
...snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.11 KB
(100%)
...ts/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.04 KB
(100%)
...est.ts-snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.05 KB
(100%)
...shots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.14 KB
(100%)
...hots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.12 KB
(100%)
...s/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.15 KB
(100%)
...st.ts-snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.14 KB
(100%)
...hots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.12 KB
(110%)
...der.test.ts-snapshots/PageHeader-With-Navigation-Slot-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+985 Bytes
(110%)
...eHeader.test.ts-snapshots/PageHeader-With-Navigation-Slot-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.2 KB
(110%)
....test.ts-snapshots/PageHeader-With-Navigation-Slot-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.12 KB
(110%)
...nts/PageHeader.test.ts-snapshots/PageHeader-With-Navigation-Slot-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.12 KB
(110%)
...der.test.ts-snapshots/PageHeader-With-Navigation-Slot-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.21 KB
(110%)
...er.test.ts-snapshots/PageHeader-With-Navigation-Slot-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.2 KB
(110%)
...test.ts-snapshots/PageHeader-With-Navigation-Slot-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.21 KB
(110%)
...ts/PageHeader.test.ts-snapshots/PageHeader-With-Navigation-Slot-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.21 KB
(110%)
...er.test.ts-snapshots/PageHeader-With-Navigation-Slot-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.04 KB
(100%)
...eHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+913 Bytes
(100%)
.../PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.13 KB
(100%)
...ader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.04 KB
(100%)
...ponents/PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.04 KB
(100%)
...eHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.15 KB
(100%)
...Header.test.ts-snapshots/PageHeader-With-Page-Layout-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.15 KB
(100%)
...der.test.ts-snapshots/PageHeader-With-Page-Layout-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.14 KB
(100%)
...onents/PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.14 KB
(100%)
...Header.test.ts-snapshots/PageHeader-With-Page-Layout-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.4 KB
(110%)
...test.ts-snapshots/UnderlineNav-Counters-Loading-State-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.31 KB
(110%)
...Nav.test.ts-snapshots/UnderlineNav-Counters-Loading-State-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.47 KB
(110%)
...t.ts-snapshots/UnderlineNav-Counters-Loading-State-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.4 KB
(110%)
...derlineNav.test.ts-snapshots/UnderlineNav-Counters-Loading-State-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.41 KB
(110%)
...test.ts-snapshots/UnderlineNav-Counters-Loading-State-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.49 KB
(110%)
...est.ts-snapshots/UnderlineNav-Counters-Loading-State-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.49 KB
(110%)
....ts-snapshots/UnderlineNav-Counters-Loading-State-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.47 KB
(110%)
...erlineNav.test.ts-snapshots/UnderlineNav-Counters-Loading-State-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.46 KB
(110%)
...est.ts-snapshots/UnderlineNav-Counters-Loading-State-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.76 KB
(100%)
...erlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.51 KB
(100%)
.../UnderlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.78 KB
(100%)
...ineNav.test.ts-snapshots/UnderlineNav-Profile-Page-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.76 KB
(100%)
...ponents/UnderlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.76 KB
(100%)
...erlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.74 KB
(100%)
...rlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.78 KB
(100%)
...neNav.test.ts-snapshots/UnderlineNav-Profile-Page-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.74 KB
(100%)
...onents/UnderlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.74 KB
(100%)
...rlineNav.test.ts-snapshots/UnderlineNav-Profile-Page-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+990 Bytes
(100%)
...eNav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+899 Bytes
(100%)
...rlineNav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1010 Bytes
(100%)
...v.test.ts-snapshots/UnderlineNav-Pull-Request-Page-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+985 Bytes
(100%)
...ts/UnderlineNav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+984 Bytes
(100%)
...eNav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1002 Bytes
(100%)
...Nav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.04 KB
(100%)
....test.ts-snapshots/UnderlineNav-Pull-Request-Page-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1005 Bytes
(100%)
...s/UnderlineNav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1007 Bytes
(100%)
...Nav.test.ts-snapshots/UnderlineNav-Pull-Request-Page-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-dark-Hi-43cdc-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-dark-Hi-a8f67-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...nderlineNav-UnderlineNav-Interactions-dark-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-284 Bytes
(97%)
...nderlineNav-UnderlineNav-Interactions-dark-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-dark-co-09dc1-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-dark-co-4ae94-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...-UnderlineNav-Interactions-dark-colorblind-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-284 Bytes
(97%)
...-UnderlineNav-Interactions-dark-colorblind-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.07 KB
(110%)
...ractions-dark-di-0885b-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.07 KB
(110%)
...ractions-dark-di-b98f2-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.07 KB
(110%)
...eNav-UnderlineNav-Interactions-dark-dimmed-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-225 Bytes
(98%)
...eNav-UnderlineNav-Interactions-dark-dimmed-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.36 KB
(110%)
...ractions-dark-hi-277e8-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.36 KB
(110%)
...ractions-dark-hi-75912-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.36 KB
(110%)
...derlineNav-Interactions-dark-high-contrast-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-440 Bytes
(96%)
...derlineNav-Interactions-dark-high-contrast-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-dark-tr-3b2b3-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-dark-tr-488ac-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...-UnderlineNav-Interactions-dark-tritanopia-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-284 Bytes
(97%)
...-UnderlineNav-Interactions-dark-tritanopia-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-light-H-38ba9-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-light-H-42961-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...derlineNav-UnderlineNav-Interactions-light-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-253 Bytes
(98%)
...derlineNav-UnderlineNav-Interactions-light-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-light-c-5b01a-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-light-c-617fb-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...UnderlineNav-Interactions-light-colorblind-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-253 Bytes
(98%)
...UnderlineNav-Interactions-light-colorblind-Overflow-interaction-vrt-4-linux.png
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. double checking that this diff is correct ? seems some shading around the "more" button is gone
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch! I reverted this snapshot change. |
Oops, something went wrong.
Binary file modified
BIN
+1.3 KB
(110%)
...ractions-light-h-7fa44-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.3 KB
(110%)
...ractions-light-h-9f6e1-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.3 KB
(110%)
...erlineNav-Interactions-light-high-contrast-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-429 Bytes
(96%)
...erlineNav-Interactions-light-high-contrast-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-light-t-c1290-t-enough-space-to-display-all-list-items-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...ractions-light-t-fd45e-t-enough-space-to-display-all-list-items-vrt-2-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.24 KB
(110%)
...UnderlineNav-Interactions-light-tritanopia-Overflow-interaction-vrt-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-210 Bytes
(98%)
...UnderlineNav-Interactions-light-tritanopia-Overflow-interaction-vrt-4-linux.png
Oops, something went wrong.
Binary file modified
BIN
+795 Bytes
(110%)
...av.test.ts-snapshots/UnderlineNav-With-Counter-Labels-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+743 Bytes
(110%)
...ineNav.test.ts-snapshots/UnderlineNav-With-Counter-Labels-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+854 Bytes
(110%)
...test.ts-snapshots/UnderlineNav-With-Counter-Labels-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+795 Bytes
(110%)
.../UnderlineNav.test.ts-snapshots/UnderlineNav-With-Counter-Labels-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+795 Bytes
(110%)
...av.test.ts-snapshots/UnderlineNav-With-Counter-Labels-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+827 Bytes
(110%)
...v.test.ts-snapshots/UnderlineNav-With-Counter-Labels-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+833 Bytes
(110%)
...est.ts-snapshots/UnderlineNav-With-Counter-Labels-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+827 Bytes
(110%)
...UnderlineNav.test.ts-snapshots/UnderlineNav-With-Counter-Labels-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+827 Bytes
(110%)
...v.test.ts-snapshots/UnderlineNav-With-Counter-Labels-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.66 KB
(120%)
...nderlineNav.test.ts-snapshots/UnderlineNav-With-Icons-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.44 KB
(120%)
...ts/UnderlineNav.test.ts-snapshots/UnderlineNav-With-Icons-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.64 KB
(120%)
...rlineNav.test.ts-snapshots/UnderlineNav-With-Icons-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.66 KB
(120%)
...omponents/UnderlineNav.test.ts-snapshots/UnderlineNav-With-Icons-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.66 KB
(120%)
...nderlineNav.test.ts-snapshots/UnderlineNav-With-Icons-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.63 KB
(120%)
...derlineNav.test.ts-snapshots/UnderlineNav-With-Icons-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.64 KB
(120%)
...lineNav.test.ts-snapshots/UnderlineNav-With-Icons-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.63 KB
(120%)
...mponents/UnderlineNav.test.ts-snapshots/UnderlineNav-With-Icons-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.63 KB
(120%)
...derlineNav.test.ts-snapshots/UnderlineNav-With-Icons-light-tritanopia-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when was the original default added? depending on the timeline this has been around, might be worth considering whether this is a major change👀
patch: we accidentally added the wrong default value in a recent release and are correcting it
major: we're changing the behavior of this component by changing this default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this default was added recently in #8133 a month ago and first shipped in 38.32.0 three weeks ago. Since this is a recent change, would a patch be reasonable? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok yeah SGTM!