Skip to content

Add merge props migration driver - #8254

Open
joshblack wants to merge 2 commits into
migrate/merge-props-eslint-toolingfrom
migrate/merge-props-migrator
Open

Add merge props migration driver#8254
joshblack wants to merge 2 commits into
migrate/merge-props-eslint-toolingfrom
migrate/merge-props-migrator

Conversation

@joshblack

@joshblack joshblack commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds the driver skill for migrating Primer React components to ADR-025.

Changelog

New

  • Add the migrate-to-merge-props coordinator skill.
  • Add the bounded migrate-to-merge-props-batch agent.

Changed

  • Document ownership boundaries for foundation tooling, the migration driver, implementation batches, and cleanup.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

This is temporary migration coordination tooling and has no public package impact.

Testing & Reviewing

Please verify the coordinator always routes adoption-tool refinements to PR #8248, keeps this entry limited to the skill and agent, and creates one stack entry per implementation batch.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4132b01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack changed the title migrate/merge props migrator Add merge props migration driver Jul 31, 2026
@joshblack
joshblack force-pushed the migrate/merge-props-migrator branch from 63f3f06 to 2dd85ec Compare July 31, 2026 18:35
@joshblack joshblack added the skip changeset This change does not need a changelog label Jul 31, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8254 July 31, 2026 18:47 Inactive
@joshblack
joshblack changed the base branch from copilot/update-style-docs-prop-merging to migrate/merge-props-eslint-tooling August 10, 2026 20:05
@joshblack
joshblack force-pushed the migrate/merge-props-migrator branch from 2dd85ec to db46abb Compare August 10, 2026 20:05
@github-actions
github-actions Bot requested a deployment to storybook-preview-8254 August 10, 2026 20:09 Abandoned
@joshblack
joshblack marked this pull request as ready for review August 10, 2026 20:11
@joshblack
joshblack requested a review from a team as a code owner August 10, 2026 20:11
@joshblack
joshblack requested review from TylerJDev and a lite review from Copilot August 10, 2026 20:11
@joshblack joshblack added the integration-tests: skipped manually Changes in this PR do not require an integration test label Aug 10, 2026
Copilot AI reviewed Aug 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds temporary migration coordination tooling to drive staged adoption of ADR-025 (prop merging conventions) across @primer/react components via bounded, stacked batches.

Changes:

  • Adds the migrate-to-merge-props coordinator skill with stack ownership rules, batching workflow, and cleanup criteria.
  • Adds a migrate-to-merge-props-batch agent definition to implement a single assigned batch and report validation + migration status evidence.
Show a summary per file
File Description
.github/skills/migrate-to-merge-props/SKILL.md Defines the coordinator workflow, stack ownership boundaries, batching rules, and cleanup steps for ADR-025 adoption.
.github/agents/migrate-to-merge-props-batch.agent.md Introduces a bounded batch agent contract for implementing one migration batch and returning evidence to the coordinator.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread .github/skills/migrate-to-merge-props/SKILL.md

- Included: findings reported in `packages/react/src/**/*.{ts,tsx}` by
`primer/prefer-merge-props`.
- Excluded: tests, stories, nested JSX, generated output, `.agents/**/*`, and
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8254 August 10, 2026 20:19 Inactive
@joshblack
joshblack force-pushed the migrate/merge-props-migrator branch from db46abb to 3d07672 Compare August 10, 2026 21:10
@joshblack
joshblack force-pushed the migrate/merge-props-migrator branch from db46abb to 3d07672 Compare August 10, 2026 21:10
@github-actions
github-actions Bot requested a deployment to storybook-preview-8254 August 10, 2026 21:14 Abandoned
@joshblack
Add merge props migration driver
680152c 
Refine the adoption report, add validated migration examples, and introduce the coordinator skill and bounded batch agent for ADR-025.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 00bfd295-6ed9-4119-8d63-103a0b3c63e8
@joshblack
Keep migration driver focused on coordination
4132b01 
Move implementation and adoption-tool changes out of the driver entry and document stack ownership for foundation, driver, batch, and cleanup work.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 00bfd295-6ed9-4119-8d63-103a0b3c63e8
@joshblack
joshblack force-pushed the migrate/merge-props-migrator branch from 3d07672 to 4132b01 Compare August 10, 2026 21:19
@github-actions
github-actions Bot requested a deployment to storybook-preview-8254 August 10, 2026 21:23 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshblack