-
Notifications
You must be signed in to change notification settings - Fork 67
[Brand Refactor] MinimalFooter updates #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielguillan
wants to merge
27
commits into
main
Choose a base branch
from
danielguillan/brand-refactor-minimal-footer-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0b15af6
Update MinimalFooter gridline layout
danielguillan 9dc7331
Update changeset
danielguillan 0aa15e2
Update MinimalFooter
danielguillan d0d612f
Fixes and cleanu
danielguillan 5b77d1b
Update changeset
danielguillan 4ff8383
Update docs
danielguillan f765dc0
Update tests
danielguillan 2a84390
Cleanup
danielguillan 23b3d7e
Rename footer regions into sections
danielguillan f768376
Layout fixes
danielguillan eb2660c
Merge main into MinimalFooter updates
danielguillan 1dc3bfc
Update snapshots
danielguillan 2e326fb
Clean up
danielguillan c700408
Update stories
danielguillan 556a9da
Fix back to top control styles
danielguillan 4f4edd0
Fix inline padding on large viewports
danielguillan 7753e6d
Update snapshots
danielguillan 75cdb82
Fix typo in docs
danielguillan b6afa65
Cleanup
danielguillan 1ca1d22
Fix alignment
danielguillan 336b41a
Fix docs
danielguillan 6481cfb
Update snapshots
danielguillan a25fef9
Merge branch 'danielguillan/brand-refactor-minimal-footer-updates' of…
danielguillan 5d65c12
Address feedback
danielguillan a05ac07
Update snapshots
danielguillan 650d791
Address feedback
danielguillan 9be256c
Auto-merged main into danielguillan/brand-refactor-minimal-footer-upd…
danielguillan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@primer/brand-primitives': minor | ||
| '@primer/react-brand': minor | ||
| --- | ||
|
|
||
| Updated `MinimalFooter` visual design and added a center component prop and back to top control. | ||
|
|
||
| - Added the optional `centerComponent` prop for exceptional page-specific content and the optional `MinimalFooter.BackToTop` control. | ||
| - Replaced the full GitHub logo with the GitHub logomark and reorganized the footer into top, center, and bottom sections. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/design-tokens/src/tokens/functional/components/footer/base.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "footer": { | ||
| "backToTop": { | ||
| "minTarget": { | ||
| "value": "{base.size.44}" | ||
| } | ||
| } | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
packages/design-tokens/src/tokens/functional/components/footer/colors.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.