Skip to content

Add uploadAsync to SyncManager #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MartinsMikroKosmos wants to merge 1 commit into from
Closed

Add uploadAsync to SyncManager #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions libpretixsync/src/main/java/eu/pretix/libpretixsync/sync/SyncManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,21 @@ public SyncResult syncMinimalEventSet(SyncManager.ProgressFeedback feedback) {
return syncMinimalEventSet(null, 0L, feedback);
}

public SyncResult uploadAsync(ProgressFeedback feedback) {

@raphaelm raphaelm Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing really async about this method, maybe

Suggested change
public SyncResult uploadAsync(ProgressFeedback feedback) {
public SyncResult uploadOnly(ProgressFeedback feedback) {

?

@MartinsMikroKosmos MartinsMikroKosmos Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i change it

if (!configStore.isConfigured()) {
return new SyncResult(false, false, null);
}
canceled.setCanceled(false);
try {
upload(feedback);
} catch (SyncException e) {
configStore.setLastFailedSync(System.currentTimeMillis());
configStore.setLastFailedSyncMsg(e.getMessage());
return new SyncResult(true, false, e);
}
return new SyncResult(true, false, null);
}

private void checkEventSelection(Long listId) throws EventSwitchRequested {
try {
if (configStore.getSynchronizedEvents().size() != 1) {
Expand Down
Loading