Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in several bugfixes which were detected during the reusable media testing for the desktop app:
When a reusable medium links several positions and none is valid at scan time, the fallback mechanism that calculates the next position used an "OR" while the server uses an AND. As a result, a past position could overwrite a future candidate depending on row order in the app database.
Changes the candidate selection to be from the filtered list instead of the raw linked position.
Exit scan in during a gap when a ticket is not valid is now also aligned with the server flow (so instead of raising invalid time, it will be allowed).
Invalid-time failed scans now upload the scanned medium identifier as the raw barcode instead of the ticket secret.
The check-in list product filter is now also applied to media with several positions.
Invalid scan for media linked to another date reports reason product