Make GetMonData and GetBoxMonData ABI-safe#763
Open
AZero13 wants to merge 1 commit into
Open
Conversation
Clang and LLVM hate this, so instead I am doing the manual work of using macros to do the equivalent of a default parameter in C++ to avoid work downstream.
mrgriffin
reviewed
Jun 17, 2026
Comment on lines
+2984
to
+2988
| #ifndef UBFIX | ||
| u32 GetBoxMonData3(struct BoxPokemon *boxMon, s32 field, u8 *data) | ||
| #else | ||
| u32 GetBoxMonData(struct BoxPokemon *boxMon, s32 field, u8 *data) | ||
| #endif |
Contributor
There was a problem hiding this comment.
Interestingly, these lines of code are different in pret/pokeemerald#2315 (at time of writing: in case of a force push see pret/pokeemerald@6f9c1a4).
(Admittedly, different in a way that I think is worse that what's here.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang and LLVM hate this, so instead I am doing the manual work of using macros to do the equivalent of a default parameter in C++ to avoid work downstream.