Remove PokenavListSub#2317
Open
mrgriffin wants to merge 3 commits into
Open
Conversation
This is probably a fakematch because LoopedTask_ReshowListFromCheckPage now contains some unidiomatic code, but I think it makes everything else clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired-by and an-alternative-to #2307,
struct PokenavListSubis removed rather than renamed.This is probably a fakematch because
LoopedTask_ReshowListFromCheckPagehas something weird going on withlistandlistAliaspointing to the same object, but I think it makes the code clearer? Or at least, I couldn't work out what the pattern between a member going instruct PokenavListandstruct PokenavListSubis supposed to be.Additionally, fix some fakematches in
LoopedTask_ReshowListFromCheckPage.