Skip to content

Upgrade to JDK 17 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 2 commits into from
Apr 22, 2026
Merged

Upgrade to JDK 17 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c7d9b
Upgrade to JDK 17
imjalpreet Apr 17, 2026
c4cc3fc
Add maven wrapper to use Maven 3.8.8
imjalpreet Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .mvn/wrapper/maven-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
wrapperVersion=3.3.4
distributionType=only-script
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.8/apache-maven-3.8.8-bin.zip
295 changes: 295 additions & 0 deletions mvnw
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 27 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>com.facebook.airlift</groupId>
<artifactId>airbase</artifactId>
<version>97</version>
<version>108</version>
</parent>

<groupId>com.facebook.hive</groupId>
Expand Down Expand Up @@ -48,6 +48,13 @@
</scm>

<properties>
<!-- Java 17 Configuration -->
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>
<project.build.targetJdk>17</project.build.targetJdk>

<!-- Skip checks -->
<air.check.skip-findbugs>true</air.check.skip-findbugs>
<air.check.skip-pmd>true</air.check.skip-pmd>
<air.check.skip-jacoco>true</air.check.skip-jacoco>
Expand Down Expand Up @@ -118,6 +125,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>4.11.0</version>
<scope>test</scope>
</dependency>

Expand Down Expand Up @@ -151,7 +159,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>2.4.3</version>
<version>3.6.0</version>
<executions>
<execution>
<goals>
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Expand Down Expand Up @@ -185,6 +193,23 @@
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M7</version>
<configuration>
<argLine>
--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED
--add-opens java.base/java.lang.reflect=ALL-UNNAMED
--add-opens java.base/java.net=ALL-UNNAMED
</argLine>
<systemPropertyVariables>
<test.tmp.dir>${project.build.directory}/test/tmp</test.tmp.dir>
</systemPropertyVariables>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/facebook/hive/orc/WriterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,15 +808,15 @@ void write(Object obj) throws IOException {
case PRIMITIVE:
switch (((PrimitiveObjectInspector) inspector).getPrimitiveCategory()) {
case SHORT:
buffer[bufferIndex++] = new Long(((ShortObjectInspector) inspector).get(obj));
buffer[bufferIndex++] = Long.valueOf(((ShortObjectInspector) inspector).get(obj));
setRawDataSize(RawDatasizeConst.SHORT_SIZE);
break;
case INT:
buffer[bufferIndex++] = new Long(((IntObjectInspector) inspector).get(obj));
buffer[bufferIndex++] = Long.valueOf(((IntObjectInspector) inspector).get(obj));
setRawDataSize(RawDatasizeConst.INT_SIZE);
break;
case LONG:
buffer[bufferIndex++] = new Long(((LongObjectInspector) inspector).get(obj));
buffer[bufferIndex++] = Long.valueOf(((LongObjectInspector) inspector).get(obj));
setRawDataSize(RawDatasizeConst.LONG_SIZE);
break;
default:
Expand Down Expand Up @@ -2190,7 +2190,7 @@ private List<Map.Entry<StreamName, BufferedStream>> cleanUpStreams() throws IOEx
}
}

indexMap.put(name, new Integer(streamList.size()));
indexMap.put(name, Integer.valueOf(streamList.size()));
streamList.add(pair);
} else {
pair.getValue().clear();
Expand Down
Loading