Include optional timezone field in StripeFooter#25
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps the Airlift airbase parent version and extends the DWRF StripeFooter protobuf schema to include an optional timezone field, required for compatibility with Hive 4.0.1. Class diagram for updated Dwrf StripeFooter protobuf with optional timezoneclassDiagram
class StripeFooter {
<<protobuf_message>>
+string timezone
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When adding the optional timezone field to the StripeFooter proto, ensure it uses a new, unique field number and maintains wire compatibility with existing readers/writers so older data and code can still be processed safely.
- After updating the proto definition, make sure the regenerated protobuf classes (and any related build configurations) are checked in and that all modules depending on this proto are still compiling against the updated definitions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When adding the optional timezone field to the StripeFooter proto, ensure it uses a new, unique field number and maintains wire compatibility with existing readers/writers so older data and code can still be processed safely.
- After updating the proto definition, make sure the regenerated protobuf classes (and any related build configurations) are checked in and that all modules depending on this proto are still compiling against the updated definitions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Draft
6 tasks
tdcmeehan
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for Hive 4.0.1 Upgrade: prestodb/presto#24571
The changes have already been tested with CI in the above-linked PR.