Skip to content

Include optional timezone field in StripeFooter#25

Merged
tdcmeehan merged 2 commits into
prestodb:masterfrom
imjalpreet:dwrfFooterTimezone
Apr 22, 2026
Merged

Include optional timezone field in StripeFooter#25
tdcmeehan merged 2 commits into
prestodb:masterfrom
imjalpreet:dwrfFooterTimezone

Conversation

@imjalpreet
Copy link
Copy Markdown
Member

Required for Hive 4.0.1 Upgrade: prestodb/presto#24571

The changes have already been tested with CI in the above-linked PR.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 20, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the Airlift airbase parent version and extends the DWRF StripeFooter protobuf schema to include an optional timezone field, required for compatibility with Hive 4.0.1.

Class diagram for updated Dwrf StripeFooter protobuf with optional timezone

classDiagram
    class StripeFooter {
        <<protobuf_message>>
        +string timezone
    }
Loading

File-Level Changes

Change Details Files
Upgrade Airlift airbase parent to align build and dependency configuration with versions required by Hive 4.0.1.
  • Update the parent airbase version in the Maven POM from 98 to 108
  • Inherit any updated plugin, dependency, and code-style configuration that comes with airbase 108
pom.xml
Extend the DWRF StripeFooter protobuf definition to carry an optional timezone field.
  • Add a new optional timezone field to the StripeFooter message in the DWRF protobuf schema
  • Ensure field numbering is compatible with existing serialized data to maintain backward/forward compatibility
  • Prepare for downstream consumers to read the timezone from the stripe footer when present
src/main/protobuf/dwrf_proto.proto

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • When adding the optional timezone field to the StripeFooter proto, ensure it uses a new, unique field number and maintains wire compatibility with existing readers/writers so older data and code can still be processed safely.
  • After updating the proto definition, make sure the regenerated protobuf classes (and any related build configurations) are checked in and that all modules depending on this proto are still compiling against the updated definitions.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- When adding the optional timezone field to the StripeFooter proto, ensure it uses a new, unique field number and maintains wire compatibility with existing readers/writers so older data and code can still be processed safely.
- After updating the proto definition, make sure the regenerated protobuf classes (and any related build configurations) are checked in and that all modules depending on this proto are still compiling against the updated definitions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tdcmeehan tdcmeehan merged commit 84e4b7d into prestodb:master Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants