Repository navigation
SHARD-638 + SHARD-654: a stop cuts a redial in flight, and a detached reaper ends every fake guest and vmm a killed test run leaves - #515
Merged
Conversation
… reaper ends every fake guest and vmm a killed test run leaves
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
presmihaylov
commented
Oct 5, 2026
…able read, so a pid a later process took is never killed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SHARD-638 and SHARD-654. Reports on SHARD-650.
Why. vzvm
settlegave up after 10s: its follow loop sat in a 30s redial (SHARD-638). A test binary killed mid-run left its fake guests and vmms running (SHARD-654).How.
followinginservices/provider/vzvm/machine.go:settleandclosecancel it; the new settle test fails at 10s without it.pkg/reaper: a detached reaper outlives the test binary and SIGKILLs every session the FC and vzvm harnesses marked, matched by start time.(body.resources.disk_mib).end()after Pause, with no ENOENT or ECONNREFUSED withinkillGrace; one probe carries the whole remaining grace. A plain SIGKILL race is ruled out: 4080 kill-then-probe runs on the Mac, none over 1s.What. One vzvm production change; the rest is tests.