feat(board): attention indicators in BoardSwitcher dropdown#1815
Open
tzercin wants to merge 3 commits into
Open
feat(board): attention indicators in BoardSwitcher dropdown#1815tzercin wants to merge 3 commits into
tzercin wants to merge 3 commits into
Conversation
Aggregate per-board counts of branches flagged needs_attention (the same signal that drives the branch-card glow from PR preset-io#161) and surface them in the board selector: - warning-colored count badge on each board menu item that has branches needing attention, alongside the existing branch-count badge - dot on the closed trigger's board icon when a *non-current* board needs attention, so users spot waiting work without opening the dropdown (attention on the current board is already visible on the canvas) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The attention badge already explained itself on hover; the branch-count badge only showed the bare number (AntD Badge's default title). Give it matching explicit text: "n branch(es) on this board". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The badge previously counted only branch.needs_attention, so a board whose sessions had just finished responding (session.ready_for_prompt) showed glowing cards but no badge. Use the same predicate as the card glow: needs_attention OR any active (non-archived) session ready for prompt. Archived branches are excluded — they're hidden from boards. AppHeader now passes the store's sessionById map through. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Before adding more metrics here, want to point towards a few things:
I think a notification framework is probably more the direction to push this. I set this aside because of a mix of complexity/focus. Feels like a large effort that requires some deep thinking/focus to "get it right". About the notif framework, it'd be actively managed to target the right people, show a notification bell in navbar, show attention indicators in the right places, to the right target people, ... See the semi-abandoned PR #1135 for directionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces "needs attention" signals in the
BoardSwitcherdropdown so users can spot boards with waiting work without opening each one. Reuses the same predicate that drives the branch-card glow (from PR #161).What changed
needs_attentionOR any active (non-archived) session that isready_for_prompt, matching the card-glow predicate so a board whose sessions just finished responding no longer shows glowing cards with no badge.AppHeadernow threads the store'ssessionByIdmap through."n branch(es) on this board") instead of AntD's bare default.Testing
Adds
BoardSwitcher.test.tsxcovering the badge aggregation, the ready-for-prompt predicate, and the trigger dot behavior.🤖 Generated with Claude Code
Screenshot:
