Add ASTE to the system tests#876
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ASTE and the aste-turbine tutorial to the system tests (related to #448).
This tutorial is different than other tutorials in many ways, which requires a few ad-hoc workarounds:
precice-config.xmland therun.sh(and the case configuration) are all in the same directory. This breaks the assumption thatprecice-exportsare always on the parent directory of where the case is executed. To address that, I am patching the path that thepreparestep adds (I cannot do this in thetests.yaml, as therun-beforehook is executed before theprepare). A step to move the directory inrun-aftercould potentially achieve the same effect.fieldcompareto always complain. For this reason, I disabled the comparison to references. I understand that the mesh is partitioned a bit differently on each run. Two logs from two consecutive runs with the same inputs:Testing on different attempts of this run (for which I eventually disabled the results comparison): https://github.com/precice/tutorials/actions/runs/29198904659