-
-
Notifications
You must be signed in to change notification settings - Fork 115
Add support for implicit coupling of Lagrangian particles #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 16 commits
b01ad23
63217b4
599c908
daccf65
9c30fbd
4f3fc17
aeb3e46
fe1ff5d
c5037fd
ebbde82
c777742
fdea0d0
61f02d1
07755e8
0b802fb
011a829
c1c1447
fff057f
79eb07b
72e0b6b
953cbd7
9550a91
d6fcdc2
ac34673
3b150ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,26 @@ | ||
| EXE_INC = \ | ||
| -I$(LIB_SRC)/finiteVolume/lnInclude \ | ||
| -I$(LIB_SRC)/finiteArea/lnInclude \ | ||
| -I$(LIB_SRC)/faOptions/lnInclude \ | ||
| -I$(LIB_SRC)/lagrangian/basic/lnInclude \ | ||
| -I$(LIB_SRC)/lagrangian/intermediate/lnInclude \ | ||
| -I$(LIB_SRC)/lagrangian/distributionModels/lnInclude \ | ||
| -I$(LIB_SRC)/meshTools/lnInclude \ | ||
| -I$(LIB_SRC)/regionModels/lnInclude \ | ||
| -I$(LIB_SRC)/regionModels/regionModel/lnInclude \ | ||
| -I$(LIB_SRC)/regionModels/surfaceFilmModels/lnInclude \ | ||
| -I$(LIB_SRC)/regionFaModels/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/ \ | ||
| -I$(LIB_SRC)/transportModels/incompressible/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/compressible/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/twoPhaseMixture/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/interfaceProperties/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/immiscibleIncompressibleTwoPhaseMixture/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/basic/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/SLGThermo/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/specie/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/thermophysicalProperties/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/reactionThermo/lnInclude \ | ||
| -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ | ||
| -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ | ||
| -I$(LIB_SRC)/TurbulenceModels/incompressible/lnInclude \ | ||
|
|
@@ -22,5 +35,15 @@ LIB_LIBS = \ | |
| -lcompressibleTurbulenceModels \ | ||
| -lincompressibleTurbulenceModels \ | ||
| -limmiscibleIncompressibleTwoPhaseMixture \ | ||
| -llagrangian \ | ||
| -llagrangianIntermediate \ | ||
| -lspecie \ | ||
| -lSLGThermo \ | ||
| -lregionModels \ | ||
| -lsurfaceFilmModels \ | ||
| -lreactionThermophysicalModels \ | ||
| -lthermophysicalProperties \ | ||
| -lregionFaModels \ | ||
| -lfiniteArea \ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am afraid I know the answer, but: Are all of these includes and linking options really needed in the main If we could modularize this feature (ideally with macros to enable/disable it) and make the dependencies optional, I would feel a bit more confident that we can maintain it in the long term and for different versions.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, unfortunately they are all necessary. Lagrangian particle considerations touch a lot. I'll see if I can find an easy way to enable / disable these additions...
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I used #ifdef statements to modularize the Lagrangian particle support within the Adapter.C and Adapter.H files. I then added variables so the Make/options files is dynamically modified. Allwmake is updated to look for the presence of an "ADAPTER_ENABLE_LAGRANGIAN" environment variable. If ADAPTER_ENABLE_LAGRANGIAN=1 then -DADAPTER_ENABLE_LAGRANGIAN is added to ADAPTER_CFLAGS and the implicitInjectionWrapper code will be built. If ADAPTER_ENABLE_LAGRANGIAN does not exist or is equal to something other than 1, then neither of these things happen. |
||
| $(ADAPTER_PKG_CONFIG_LIBS) \ | ||
| -lprecice | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated change |
|
MakisH marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| makeImplicitInjectorsKinematic.C | ||
| makeImplicitInjectorsKinematicColliding.C | ||
| makeImplicitInjectorsThermo.C | ||
| makeImplicitInjectorsReacting.C | ||
| makeImplicitInjectorsReactingMultiphase.C | ||
|
|
||
| LIB = $(FOAM_USER_LIBBIN)/libimplicitInjectors |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| EXE_INC = \ | ||
| -I$(LIB_SRC)/finiteVolume/lnInclude \ | ||
| -I$(LIB_SRC)/lagrangian/basic/lnInclude \ | ||
| -I$(LIB_SRC)/lagrangian/intermediate/lnInclude \ | ||
| -I$(LIB_SRC)/lagrangian/distributionModels/lnInclude \ | ||
| -I$(LIB_SRC)/meshTools/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/basic/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/specie/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/thermophysicalProperties/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/reactionThermo/lnInclude \ | ||
| -I$(LIB_SRC)/thermophysicalModels/SLGThermo/lnInclude \ | ||
| -I$(LIB_SRC)/regionModels/regionModel/lnInclude \ | ||
| -I$(LIB_SRC)/regionModels/surfaceFilmModels/lnInclude \ | ||
| -I$(LIB_SRC)/regionFaModels/lnInclude \ | ||
| -I$(LIB_SRC)/finiteArea/lnInclude \ | ||
| -I$(LIB_SRC)/faOptions/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/incompressible/lnInclude \ | ||
| -I$(LIB_SRC)/transportModels/compressible/lnInclude | ||
|
|
||
| LIB_LIBS = \ | ||
| -lfiniteVolume \ | ||
| -llagrangian \ | ||
| -llagrangianIntermediate \ | ||
| -ldistributionModels \ | ||
| -lmeshTools \ | ||
| -lfluidThermophysicalModels \ | ||
| -lspecie \ | ||
| -lthermophysicalProperties \ | ||
| -lSLGThermo \ | ||
| -lregionModels \ | ||
| -lsurfaceFilmModels \ | ||
| -lregionFaModels \ | ||
| -lfiniteArea \ | ||
| -lfaOptions \ | ||
| -lcompressibleTransportModels \ | ||
| -lincompressibleTransportModels |
Uh oh!
There was an error while loading. Please reload this page.