Update OpenFOAM-OpenFOAM tutorials according to major preCICE config changes - #107
Conversation
| <relative-convergence-measure limit="1.0e-6" data="Temperature" mesh="Fluid-Mesh"/> | ||
| <extrapolation-order value="2"/> | ||
| <post-processing:IQN-ILS> | ||
| <acceleration:IQN-ILS> |
There was a problem hiding this comment.
This corrensponds to a diferent change in preCICE, but since in the tutorials repository they are treated as one, it's ok to treat it as one here as well.
There was a problem hiding this comment.
However, we need to update this for every tutorial.
There was a problem hiding this comment.
precice/tutorials#60 already contains this change. E.g. here. Sorry, if I am causing confusion. I thought that #107 is just the OpenFOAM version of precice/tutorials#60. (And it is more convenient for our current testing problems, if the breaking changes are not scattered)
There was a problem hiding this comment.
Yes, but we have more tutorials here (i.e. the nearest-projection variant). Just let me take care of this.
There was a problem hiding this comment.
And it is more convenient for our current testing problems, if the breaking changes are not scattered
I think I can hack around this problem in my testing branch (see precice/systemtests@2460f9a). Therefore, you can ignore this argument. If you want to keep things separated, feel free to git revert 1e826a8
|
This is ready to merge, but the system tests fail with unclear reason. |
|
The error in this tests seems to be the same one that is currently being worked on in precice/systemtests#150. When triggering a test here, we should therefore have it run on the branch of the PR. However, the triggering script used here Line 11 in eb94d5a is taken from the master branch of systemtests. That script version in turn is quite old and only runs tests on systemtests/master, which doesn't contain the aforementioned fixes from precice/systemtests#150. The functionality for triggering on different branches is currently in precice/systemtests#143. So, to run the test, we could alter the .travis.yml file here to first pull the new script version from PR 143 and then run on PR 150: |
…changes (#107) * Tutorials: remove parallel versions of precice-config.xml * Tutorials: Update config files for parallel simulations * Replace post-processing with acceleration * Replace post-processing with acceletation (NP tutorial) Co-authored-by: Benjamin Rüth <benjamin.rueth@tum.de>
…changes (#107) * Tutorials: remove parallel versions of precice-config.xml * Tutorials: Update config files for parallel simulations * Replace post-processing with acceleration * Replace post-processing with acceletation (NP tutorial) Co-authored-by: Benjamin Rüth <benjamin.rueth@tum.de>
This PR applies the same changes as precice/tutorials#60, namely:
precice-config_parallel.xmlfiles. We don't needmpi-singleto run parallel cases anymore. Furthermore,distribution-typeis removed from preCICE (breaking change).precice-config_serial.xmltoprecice-config.xml, replacing the respective link.runFluid,runSolid,Allrun,Allrun_parallel.Depends on precice/precice#572.