Refactored LoadBalancing into an interface#300
Merged
Conversation
Snapex2409
force-pushed
the
refactor-diagnostics
branch
from
7e3ee74 to
86dcebd
Compare
Snapex2409
force-pushed
the
refactor-diagnostics
branch
from
86dcebd to
3818aae
Compare
Snapex2409
force-pushed
the
refactor-diagnostics
branch
from
3818aae to
afe833a
Compare
Snapex2409
force-pushed
the
refactor-diagnostics
branch
from
afe833a to
d1e8e84
Compare
# Conflicts: # micro_manager/adaptivity/adaptivity.py # micro_manager/adaptivity/local_adaptivity.py # micro_manager/crash_handler.py # micro_manager/interpolation.py # micro_manager/micro_manager.py
note: files not yet added to git are also not tracked by pre-commit
# Conflicts: # micro_manager/tools/diagnostics.py
# Conflicts: # micro_manager/micro_manager.py
IshaanDesai
reviewed
Jul 12, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
Thanks for this. I have only minor suggestions and a few questions to clarify. I will now run a load-balancing regression test on this PR to ensure the underlying functionality has not changed.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
IshaanDesai
approved these changes
Jul 12, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
Tested it with a regression test of the two-scale heat conduction.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored LoadBalancing into an interface to reduce confusion for ActiveBalancer.
Moved counters from MicroManager to LoadBalancer implementations.
NOTE: Merge this PR after #299
Checklist:
CHANGELOG.md.