Repository navigation
HOL-Light: Minor clean-ups - #1502
Draft
mkannwischer wants to merge 4 commits into
Draft
mkannwischer wants to merge 4 commits into
mkannwischer wants to merge 4 commits into
Conversation
An instruction loop often applies the same arithmetic simplifier after each step. Building SIMD_SIMPLIFY_TAC inside the instruction callback rebuilds its rewrite conversion each time. The abbreviation variant also rebuilt that conversion for every selected register equation. Prepare the ARM/x86 step and SIMD tactics once before their loops. Move conversion construction and definition selection out of the abbreviation helper's per-fact callback. Still read local arithmetic equations from the current context: these change during execution. No converter-builder cache is needed. Prepared conversions capture the basic rewrite table; prepare again if it or the arithmetic rules change. Keep ordinary whole-context abbreviation, machine code and proof claims. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
After the NTT output congruence has been reduced to a real polynomial, REAL_INTEGER_TAC proves integer closure from the expression's structure. It does not consult context facts, but its recursive subgoals still carried the large execution context. Discard that context immediately before the four ARM/x86 NTT and INTT integer-closure calls. Leave instruction reasoning, congruence rewriting, output bounds and HOL Light's tactic unchanged. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
aarch64_utils.ml redefined SIMD_SIMPLIFY_CONV and SIMD_SIMPLIFY_TAC, shadowing the shared definitions in common/mldsa_specs.ml that it already loads. The conversion is identical and the shared tactic only additionally matches x86 int256 registers, which never occur in Arm goals, so use the shared definitions. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
ARM_STEPS_TAC and X86_STEPS_TAC do no work until they receive the step numbers, so binding them to the exec theorem outside a loop does not save anything. Only keep the prepared SIMD simplifier outside the loop. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (407 configurations)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (407 configurations)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (407 configurations)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (407 configurations)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (407 configurations)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (407 configurations)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.