Repository navigation
HOL Light: Fail bytecode update if a proof's bytecode is not dumped - #1497
Draft
mkannwischer wants to merge 1 commit into
Draft
mkannwischer wants to merge 1 commit into
mkannwischer wants to merge 1 commit into
Conversation
The AArch64 dump_bytecode.ml did not dump the five Keccak objects, so `autogen --update-hol-light-bytecode` silently skipped their proofs. Add the missing entries, and make autogen require, for every assembly file in proofs/hol_light/<arch>/mldsa, a proof file with BYTECODE START/END markers and matching bytecode in the dump. This isn't a soundness risk as outdated bytecode is caught when the proof itself runs, but it is still desirable to also catch outdated bytecode earlier. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
force-pushed
the
bytecode-autogen
branch
from
October 25, 2026 15:04
c654b75 to
1576d3e
Compare
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (397 configurations)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (397 configurations)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (397 configurations)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (397 configurations)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (397 configurations)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (397 configurations)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AArch64 dump_bytecode.ml did not dump the five Keccak objects, so
autogen --update-hol-light-bytecodesilently skipped their proofs. Add the missing entries, and make autogen require, for every assembly file in proofs/hol_light//mldsa, a proof file with BYTECODE START/END markers and matching bytecode in the dump.This isn't a soundness risk as outdated bytecode is caught when the proof itself runs, but it is still desirable to also catch outdated bytecode earlier.