Skip to content

Make more strings localizable#37655

Open
skueee wants to merge 3 commits intoppy:masterfrom
skueee:make-more-strings-localizable
Open

Make more strings localizable#37655
skueee wants to merge 3 commits intoppy:masterfrom
skueee:make-more-strings-localizable

Conversation

@skueee
Copy link
Copy Markdown

@skueee skueee commented May 6, 2026

This commit moves several hard-coded strings to localization files to make them translatable.
The biggest change is the mods descriptions, but there are also some changes in the editor, the matchmaking system, the score ranking statistics screen, and the spectate screen.

@skueee skueee marked this pull request as draft May 6, 2026 14:30
@skueee skueee force-pushed the make-more-strings-localizable branch from c21a4cc to 3969bf8 Compare May 6, 2026 14:46
@skueee skueee marked this pull request as ready for review May 6, 2026 14:48
@diquoks
Copy link
Copy Markdown
Contributor

diquoks commented May 6, 2026

  1. strings used in rulesets currently do not support localisation, as described in Ruleset projects should be able to contain localisation strings #35641
  2. based on the first point, mods' descriptions and parameters also shouldn't be localised, because it would lead to some confusion
  3. ranked play is currently WIP and the interface will be completely redesigned in the future, so localising it is useless
  4. size. who should be the person who checks a 1k lines of code in one commit?
    changes should be separated according to their's scope

@skueee skueee force-pushed the make-more-strings-localizable branch from 55077f4 to 36d4515 Compare May 6, 2026 14:57
public static LocalisableString EndedStatus => new TranslatableString(getKey(@"ended_status"), @"Thanks for playing! The match will close shortly.");


private static string getKey(string key) => $@"{prefix}:{key}";
@peppy
Copy link
Copy Markdown
Member

peppy commented May 7, 2026

congratulations, you just wasted a ton of time

please try and avoid belittling new contributes

you've made some changes that change everything except localisation

what does this one mean?

P.S.: You created osu fork just yesterday, so i don't rule out that some of the code was written using AI tools, which violates CONTRIBUTING.md

i'd rather we don't start by threatening new users. at that point i'll just turn off PRs to avoid this contention.

@diquoks
Copy link
Copy Markdown
Contributor

diquoks commented May 7, 2026

congratulations, you just wasted a ton of time

please try and avoid belittling new contributes

you've made some changes that change everything except localisation

what does this one mean?

P.S.: You created osu fork just yesterday, so i don't rule out that some of the code was written using AI tools, which violates CONTRIBUTING.md

i'd rather we don't start by threatening new users. at that point i'll just turn off PRs to avoid this contention.

sorry for the unintentional rage, should be better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants