Allow spectator and replay gameplay to load even when window is inactive#37633
Open
peppy wants to merge 1 commit intoppy:masterfrom
Open
Allow spectator and replay gameplay to load even when window is inactive#37633peppy wants to merge 1 commit intoppy:masterfrom
peppy wants to merge 1 commit intoppy:masterfrom
Conversation
This used to be the case, but recently changed with the introduction of [pausing when inactive](ppy#37100). The change was intended to work for local gameplay modes, but it makes less sense for spectator/replay where you may want to be watching in the background while doing something else. Raised via email.
bdach
reviewed
May 7, 2026
Collaborator
bdach
left a comment
There was a problem hiding this comment.
This doesn't work for replay-generating mods like Autoplay or Cinema. It's unclear to me whether that is intentional or not.
This is because in song select, it can be that a normal PlayerLoader (as opposed to a ReplayPlayerLoader) pushes a ReplayPlayer.
osu/osu.Game/Screens/Select/SoloSongSelect.cs
Lines 127 to 145 in c28c649
If this is unintentional / broken, then I can think of the following fixes:
- Changing above code such that
ReplayPlayerLoaderis pushed to begin with if a replay-generating mod is present - Exposing
WindowShouldBeActiveForGameplayas public rather than protected and setting it in the broken usage site as required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to be the case, but recently changed with the introduction of pausing when inactive. The change was intended to work for local gameplay modes, but it makes less sense for spectator/replay where you may want to be watching in the background while doing something else.
Raised via email.