Add report dropdown to ranked play chat#37617
Open
LiquidPL wants to merge 1 commit intoppy:masterfrom
Open
Conversation
This commit adds a dropdown menu to ranked play chat messages, with an option to report said message. However, this isn't fully working yet due to some focus shenanigans: * the chat history is only displayed when the chat textbox is in focus, * selecting the report option in a dropdown kills focus on the textbox, hiding the messages, which in turn causes the report popover to expire Because of that, this PR is for now mostly an RFC concerning the changes I've made to the actual chat display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a dropdown menu to ranked play chat messages, with an option to report said message. However, this isn't fully working yet due to some focus shenanigans:
Because of that, this PR is for now mostly an RFC concerning the changes I've made to the actual chat display. I think the report popover will need to be refactored to some sort of fullscreen overlay (
DialogOverlaymaybe?) since this is the second time I have to fight those (previous being #36335).Screencast_20260503_081506.webm