Broaden IntentFilter filetype support and add labels for specific filetypes in external Android applications#37614
Open
smyalygames wants to merge 2 commits intoppy:masterfrom
Open
Broaden IntentFilter filetype support and add labels for specific filetypes in external Android applications#37614smyalygames wants to merge 2 commits intoppy:masterfrom
smyalygames wants to merge 2 commits intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The main goal of this PR is to fix opening files outside of osu! without having to share or import it through the osu! interface, partially related to #11911.
From what I understand the main problem is how certain applications pass the content URI to the file as mentioned on this Stack Overflow post and it's why I added the broader MIME types. From what I gathered, Files by Google views the osu! files as
application/octet-stream, and that's why you couldn't open it normally before this PR. However, Material Files does also see it as aapplication/octet-stream, but I assume the content URI ends with the correct file extension.I also added labels when opening/sharing the file to osu!, as can be seen in this screenshot from opening the files with Material Files:
