Skip to content

Remember friend status filter when reopening friends list panel#37600

Open
forer-lika777 wants to merge 3 commits intoppy:masterfrom
forer-lika777:feature/remember-friends-list-filter
Open

Remember friend status filter when reopening friends list panel#37600
forer-lika777 wants to merge 3 commits intoppy:masterfrom
forer-lika777:feature/remember-friends-list-filter

Conversation

@forer-lika777
Copy link
Copy Markdown

The friend status filter resets to "All" every time the friend list panel is reopened, or when switching back from other tabs ("currently online" and "user search").
I created a statusFilter property in DashboardOverlay, which is bound to the current item of streamControl in FriendDisplay to save this setting. Filter setting will still reset to "All" after reopening the whole game.

Changes:

  • Added statusFilter to DashboardOverlay
  • Exposed StatusFilter bindable in FriendDisplay
  • Bound FriendOnlineStreamControl.Current to the shared filter

This is only a small change, so I didn't write any test. (I have manually tested it)

@Joehuu
Copy link
Copy Markdown
Member

Joehuu commented May 2, 2026

Filter setting will still reset to "All" after reopening the whole game.

I think it should save like web and the other settings:

SetDefault(OsuSetting.DashboardSortMode, UserSortCriteria.LastVisit);
SetDefault(OsuSetting.DashboardDisplayStyle, OverlayPanelDisplayStyle.Card);

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels May 2, 2026
@forer-lika777 forer-lika777 force-pushed the feature/remember-friends-list-filter branch from bcf79f8 to 50dc113 Compare May 2, 2026 04:13
@pull-request-size pull-request-size Bot added size/XS and removed size/S labels May 2, 2026
@forer-lika777
Copy link
Copy Markdown
Author

Filter setting will still reset to "All" after reopening the whole game.

I think it should save like web and the other settings:

SetDefault(OsuSetting.DashboardSortMode, UserSortCriteria.LastVisit);
SetDefault(OsuSetting.DashboardDisplayStyle, OverlayPanelDisplayStyle.Card);

Well I didn't notice this behavior on the web. I have changed the way the filter setting is saved, just like the sort criteria and display style settings in UserListToolbar.
The game will now remember this setting across all sessions.

Comment thread osu.Game/Configuration/OsuConfigManager.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants