Remember friend status filter when reopening friends list panel#37600
Open
forer-lika777 wants to merge 3 commits intoppy:masterfrom
Open
Remember friend status filter when reopening friends list panel#37600forer-lika777 wants to merge 3 commits intoppy:masterfrom
forer-lika777 wants to merge 3 commits intoppy:masterfrom
Conversation
Member
I think it should save like web and the other settings: osu/osu.Game/Configuration/OsuConfigManager.cs Lines 246 to 247 in a3b8b9a |
bcf79f8 to
50dc113
Compare
Author
Well I didn't notice this behavior on the web. I have changed the way the filter setting is saved, just like the sort criteria and display style settings in UserListToolbar. |
Joehuu
reviewed
May 2, 2026
Joehuu
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The friend status filter resets to "All" every time the friend list panel is reopened, or when switching back from other tabs ("currently online" and "user search").
I created a statusFilter property in DashboardOverlay, which is bound to the current item of streamControl in FriendDisplay to save this setting. Filter setting will still reset to "All" after reopening the whole game.
Changes:
statusFiltertoDashboardOverlayStatusFilterbindable inFriendDisplayFriendOnlineStreamControl.Currentto the shared filterThis is only a small change, so I didn't write any test. (I have manually tested it)