Skip to content

Change taiko hit flying animation to be rate independent#37541

Open
peppy wants to merge 6 commits intoppy:masterfrom
peppy:taiko-hits-animation-rate-unaffected
Open

Change taiko hit flying animation to be rate independent#37541
peppy wants to merge 6 commits intoppy:masterfrom
peppy:taiko-hits-animation-rate-unaffected

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented Apr 26, 2026

While the default hasn't changed, users that prefer how stable behaved can now toggle the new toggle to get their preferred animation behaviour back.

osu.2026-04-27.at.07.33.41.mp4

Alternative to and closes #37529.
See #37131.

Matches stable. Not a toggle for now, but we could make it one if
there's any pushbash against this (let's see).
@huuishuu
Copy link
Copy Markdown

Just wanna mention that I did make a discussion post about this exact issue about 1 month ago here: #37131

I was planning on making it an issue initially but was encouraged to make it a discussion first.

@Tenexxt
Copy link
Copy Markdown
Contributor

Tenexxt commented Apr 26, 2026

I personally like the animation not being rate dependant currently. It makes it feel like the game is actually slowed down and not just the gameplay, which I can see why others don't like, but i've been playing osu!taiko on lazer for so long now I'm not sure if I'll be able to play without this to some extent. It just feels like a nice detail the game had.

Please make this a toggle if possible so everyone can be happy 🙏

Comment thread osu.Game/Localisation/RulesetSettingsStrings.cs Outdated
@peppy peppy requested a review from smoogipoo April 29, 2026 03:52
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
smoogipoo
smoogipoo previously approved these changes May 7, 2026
smoogipoo
smoogipoo previously approved these changes May 7, 2026
@bdach bdach self-requested a review May 7, 2026 06:06

this.ScaleTo(0.8f, gravity_time * 2, Easing.OutQuad);
// Rate independent to match stable.
double length = gravity_time * (rateAdjustedHitAnimations.Value ? 1 : Clock.Rate);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat minor point, but this should probably be using GameplayClock.GetTrueGameplayRate() if available.

This matters in replays, because with this code as written, messing with replay playback speed affects the flying hit animation:

Screen.Recording.2026-05-07.at.08.31.06.mov

@bdach bdach moved this from Inbox to Pending Review in osu! team task tracker May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

6 participants