Add Noto CJK font with weights#36870
Closed
MayoCollector wants to merge 2 commits into
Closed
Conversation
Joehuu
added
the
area:localisation
Contributor
|
This PR only includes previews for Korean characters. Do Chinese and Japanese variants also display correctly and can be distinguished from each other? |
Contributor
Author
|
includes Korean, Chinese, and Japanese language. |
Contributor
|
Are you aware of ppy/osu-resources#394? |
Contributor
Author
|
no. this PR ( #36870 ) adds |
Member
|
Why? Where does this requirement come from? Please open an issue or discussion first. This bloats the game by almost 100 mb and as far as I know we don't have an official requirement for this to exist yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Noto CJK font with regular, light, semi bold, and bold weight.