Add BASSloud libraries - #6233
Open
smallketchup82 wants to merge 2 commits into
Open
Conversation
smoogipoo
self-requested a review
April 5, 2024 08:00
Author
|
Marking this PR as a draft for now since I plan on rebasing it on top of #6352 Will likely force push the previous diffs away. |
smallketchup82
marked this pull request as draft
August 19, 2024 01:06
smallketchup82
force-pushed
the
bass-loudness-normalization
branch
from
October 16, 2024 22:28
6349227 to
ff6ac5b
Compare
Author
|
I've rebased the branch on top of master and cleaned up history a bit. Here's a full changelog:
For anyone that has this branch cloned locally, I'd recommend fetching and resetting to the remote branch head. Or delete and check out this branch again. I've confirmed with most that I know that have this branch cloned and made sure they do not have any local changes. |
smallketchup82
marked this pull request as ready for review
October 16, 2024 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for ppy/osu#27793 and #6281
Would be wise to wait for peppy/ManagedBass#1 to get merged before reviewing this
This PR adds BASSloud libraries to osu-framework.
The only issue I've found with this PR is that osu! might not open on arm windows due to bassloud not being found, as there's no arm version for bassloud.
As usual, you'll have to make a new version of
ppy.Framework.NativeLibsupon merging