Fix wrong bytes per sample in TrackBass#6039
Merged
Merged
Conversation
Collaborator
|
How did you notice this? Does this have any meaningful impact on anything? Not to say that it won't be merged even if it's correct, it probably will be merged after verification, just wondering how this would ever get spotted. |
Waveform will also no longer bring the constant from TrackBass since Waveform still uses float samples.
Contributor
Author
|
I could find because I have been working on #6002 which also uses BASS to decode, was just reading TrackBass and spotted this. This PR probably has impact on nothing since the old value (4) was already correct enough since a sample frame has 2 channels. |
7b22710 to
9756229
Compare
smoogipoo
approved these changes
Oct 31, 2023
smoogipoo
left a comment
Contributor
There was a problem hiding this comment.
Lgtm. It used to have Float specified, but that caused issues with macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BASS uses 16-bit samples by default if neither BassFlags.Byte nor BassFlags.Float is specified. (https://www.un4seen.com/doc/#bass/BASS_StreamCreate.html)
You can find this out by applying the following diff:
Waveform will no longer bring the constant from TrackBass since Waveform still uses float samples.