Added Fedora OS support - #791
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bkhadars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
size/L
|
/cc @sudeeshjohn please review |
| } | ||
| } else { | ||
| if err = mount("nouuid", bootDev, bootMount); err != nil { | ||
| return err |
There was a problem hiding this comment.
could you please check if "defaults" work for other filesystem types as well ?
| mv /etc/resolv.conf.orig /etc/resolv.conf || true | ||
| touch /.autorelabel | ||
| setfiles -F /etc/selinux/targeted/contexts/files/file_contexts / | ||
| ` |
There was a problem hiding this comment.
this is already part of the code
| return err | ||
| } | ||
| if !supported { | ||
| klog.Errorln("to create fedora ova image btrfs support should be available in the kernel]") |
There was a problem hiding this comment.
Request to make this little more clear,
|
can we review and merge this PR? |
4 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #737
Special notes for your reviewer:
**Output/Demonstration
fedora distribution support is added to pvsdm