Repository navigation
Fix notifyUpdate for setTargetV/Q - #4120
Merged
Merged
Conversation
…ethods in GeneratorImpl and BatteryImpl Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
…l and BatteryImpl Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
olperr1
requested changes
Sep 30, 2026
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
…orImpl Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
olperr1
approved these changes
Oct 2, 2026
|
olperr1
pushed a commit
that referenced
this pull request
Oct 5, 2026
* Add previous `notifyUpdate` calls for `setTargetQ` and `setTargetV` methods in GeneratorImpl and BatteryImpl * Fix `notifyUpdate` calls and tests for `setTargetQ/V` in GeneratorImpl and BatteryImpl * Add `notifyUpdate` call in `setLocalTargetV` method of ShuntCompensatorImpl Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com> (cherry picked from commit ec075bf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
localTargetQlocalTargetVand/orVoltageRegulation.TargetValuetargetQWhat is the new behavior (if this is a feature change)?
localTargetQand the deprecated notificationtargetQlocalTargetVand/orVoltageRegulation.TargetValueand the deprecated notificationtargetVlocalTargetQand the deprecated notificationtargetQDoes this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: