fix(interactive): prevent looping forever when input cannot be read - #112
Open
npmania wants to merge 1 commit into
Open
fix(interactive): prevent looping forever when input cannot be read#112npmania wants to merge 1 commit into
npmania wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfirmPromptdiscards the error fromReadString, so when there's no readable input the empty string hitsdefaultand loops forever.Non-interactive runs that reach a prompt will spin. In my case
topf nodeswith stdin closed hitNo secrets.yaml found for cluster X. Generate a new one?and wrote 575MB in 8 seconds.apply,reset,upgradeshare the confirm prompt.Not applying
errors.Is(err, io.EOF)since a closed fd or a detached tty will giveos.ErrClosedandEIO, which loop just the same. It will end up having to cover all kinds of cases that can occur in different environments.I have put the check after the switch so
printf 'y' | topfstill works, becauseReadStringreturns the data andio.EOFtogether.