Proper bindings to rust library in R package#281
Draft
thomasp85 wants to merge 7 commits intoposit-dev:mainfrom
Draft
Proper bindings to rust library in R package#281thomasp85 wants to merge 7 commits intoposit-dev:mainfrom
thomasp85 wants to merge 7 commits intoposit-dev:mainfrom
Conversation
|
I recommend referring to the sedonadb package to build inside monorepo. |
Collaborator
Author
|
I'm afraid I'm not entirely sure what the relevance to this PR is? |
|
Oh, sorry. I just wanted to point out that, as you can see from the current CI failure in this type of monorepo, Rust-based R packages cannot pass R CMD checks without some workarounds. |
Collaborator
Author
|
Ah, gotcha. Thanks for the suggestion. I'm not worrying about CI with this PR just yet🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.