Add watermark icon to interactive editor#279
Merged
georgestagg merged 2 commits intomainfrom Apr 8, 2026
Merged
Conversation
Collaborator
|
Part of me want it on the upper-right corner instead of lower-right... also, perhaps a very gentle grow-shrink cycle will make it more clear that this is ✨interactive✨ |
Collaborator
Author
|
I moved it to the top and added a pulsing animation, something like that? Screen.Recording.2026-04-07.at.17.16.05.mov |
thomasp85
approved these changes
Apr 8, 2026
Collaborator
thomasp85
left a comment
thomasp85
left a comment
There was a problem hiding this comment.
LGTM - we can always adjust after an evaluation period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlays the ggsql icon as a watermark on the Monaco editor in interactive examples. The intension is to suggest to the user that the code block is editable, it is handy that the ggsql icon looks like a pencil for this!
Closes #259.