-
Notifications
You must be signed in to change notification settings - Fork 10
Ridgeline plot #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ridgeline plot #242
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
35f622b
add ridge parameter
teunbrand f3c11be
add docs
teunbrand 9b06c4c
add test
teunbrand a86c757
Merge branch 'main' into ridgeline
teunbrand 9297edf
cargo fmt
teunbrand 9fd08b1
Merge branch 'main' into ridgeline
teunbrand 0c9a38c
rename `ridge` to `align`
teunbrand fe6555e
fix example
teunbrand 6276aa6
Allow `width` to exceed 1 for ridgeline purposes
teunbrand 067a587
rename the parameter to 'side'
teunbrand ed54f16
offset variable doesn't need encoding channel, we already have xOffse…
teunbrand 92fb952
relative-to-axis consistency of synonymous `side`
teunbrand 103cc95
cover all cases in tests
teunbrand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't left and 'bottom' be synonyms? those are the two that pointing towards the low end of the scale...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vegalite calculations just worked out this way, but I kinda agree that such consistency would be nice.