remove unnecessarry comma from cosmic-applet-time#1393
Open
Lucas-BRT wants to merge 1 commit into
Open
Conversation
cosmic-applet-timecosmic-applet-time
jacobgkau
requested changes
May 13, 2026
Member
jacobgkau
left a comment
There was a problem hiding this comment.
I only need to know if in some other language this comma is necessary by some reason.
It's necessary for English, so we can't accept the PR in its current form. This is the before/after:
Removing the comma leaves numbers separated by no punctuation, which we generally need to avoid. Any change to the current comma would need to be approved by the UX team.
A fix specific to your language could potentially be accepted. It seems weird we'd use an internationalization formatter and then have to touch up the result, though. Is it possible this is something that could be improved upstream in ICU4X instead of specifically in this applet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the system locale is set to
pt-BR, the date displayed in the top or bottom panel includes a comma between the abbreviated month and the time, resulting in two consecutive punctuation marks:25 de abr., 09:35.The vertical layout is not affected because it formats date and time separately.
The horizontal layout, however, combines them via ICU4X's datetime combining pattern for
pt-BR, which appears to be"{1}, {0}"(comma-separated) instead of"{1} {0}".The
.is correct, it belongs to the abbreviated month (abr.).The problem is the
,that ICU4X inserts as a separator between the date and time parts, producing the awkward.,sequence which is not natural in Brazilian Portuguese.Steps to reproduce
pt-BRExpected behavior
25 de abr. 09:35with no comma between date and time.Proposed fix
Strip the combining comma from the formatted string for
pt-BR, or format dateand time separately and concatenate with a space, similar to what the vertical
layout already does.
I only need to know if in some other language this comma is necessary by some reason.