Skip to content

fix(minimize): close the tooltip after opening a minimized app #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hammerlink wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(minimize): close the tooltip after opening a minimized app #1324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions cosmic-applet-minimize/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,17 +212,27 @@ impl cosmic::Application for Minimize {
return iced::window::maximize(self.core.main_window_id().unwrap(), true);
}
ToplevelUpdate::Remove(handle) => {
let prev_was_empty = self.apps.is_empty();
let prev_size = self.apps.len();
self.apps
.retain(|a| a.toplevel_info.foreign_toplevel != handle);
self.apps.shrink_to_fit();
let changed = prev_was_empty != self.apps.is_empty();
if self.apps.is_empty() && changed {
// hide the window
return iced::window::minimize(
self.core.main_window_id().unwrap(),
true,
if prev_size != self.apps.len() {
let destroy_tooltip_task = cosmic::task::message(
cosmic::Action::Cosmic(cosmic::app::Action::Surface(
surface::Action::DestroyTooltipPopup,
)),
);
if self.apps.is_empty() {
return Task::batch(vec![
destroy_tooltip_task,
iced::window::minimize(
self.core.main_window_id().unwrap(),
true,
),
]);
} else {
return destroy_tooltip_task;
}
}
}
},
Expand Down