Fix stale frame routing in hotkey and speed control flows#871
Open
CMJNB wants to merge 3 commits intopolywock:masterfrom
Open
Fix stale frame routing in hotkey and speed control flows#871CMJNB wants to merge 3 commits intopolywock:masterfrom
CMJNB wants to merge 3 commits intopolywock:masterfrom
Conversation
Contributor
Author
|
Thanks for the fix and iteration, really appreciate the effort.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
After page navigation or iframe recreation, stale frame IDs can remain in media cache.
This may cause hotkeys or speed-related messages to be sent to dead frames on first attempt.
Changes
m:scope:tabId:frameIdentry and reselect.frameId=0when the original frame is unavailable.Scope
Files
src/background/utils/getAutoMedia.tssrc/utils/configUtils.tssrc/background/utils/processKeybinds.tsValidation
npm run dev).